Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Export public types, update DU config #210

Merged
merged 64 commits into from
Mar 11, 2021
Merged

Export public types, update DU config #210

merged 64 commits into from
Mar 11, 2021

Conversation

@teogeb
Copy link
Contributor

@teogeb teogeb commented Mar 2, 2021 •
edited
Loading

Export parameters/return types for objects which are publicly available to the JS-client users.

Updated getDataUnionMainnetAddress and getDataUnionSidechainAddress in Contracts.ts to support new DataUnion addresses.

BREAKING CHANGE:

  • moved DataUnion related StreamrClient options into a new dataUnion block: factoryMainnetAddress, factorySidechainAddress, minimumWithdrawTokenWei
  • renamed payForSignatureTransport to freeWithdraw and reversed the value
  • new required options in that block: templateMainnetAddress, templateSidechainAddress

@teogeb teogeb changed the title WIP: Export public types Export public types Mar 2, 2021
@teogeb teogeb requested a review from timoxley March 2, 2021 15:15
teogeb and others added 24 commits March 3, 2021 13:17
@teogeb
Merge branch '5.x' into export-public-types
579b683
@teogeb
Strip internal methods/field from TS definitions
d61902a
@teogeb
Merge branch '5.x' into export-public-types
2e5d2fa
@teogeb
Update imports
988ceab
@timoxley
Re-add webpack export default CommonJS interop workaround.
b6edfb8
@teogeb
Support for require('streamr-client') syntax
1c4be12
@teogeb
Explicit config for browser
d7b872d
@teogeb
Revert "Explicit config for browser"
84baf34 
This reverts commit d7b872d.
@timoxley
Use streamr-docker-dev-action@v1.0.0-alpha.3 over alpha.2 to get ifco…
38a2c45 
…nfig fix in CI.
@teogeb
Debug
de6fa52
@teogeb
Debug
074df02
@teogeb
Debug
c73e5c8
@teogeb
Debug
b42bc05
@teogeb
Revert debugs
799ade1
@teogeb
Use java8 to run streamr-client-testing
509e746
@teogeb
Debug: explicit config for browser
e5dc738
@teogeb
Drop support for require('streamr-client') -> use import instead
02caa7f
@teogeb
Remove ErrorCode.ts
f2f08ed
@teogeb
Export Todo type
d4d9c6c
@teogeb
createStream doesn't require all StreamProperties
f6d84cc
@teogeb
export Stream.Field type
263dd12
@teogeb
Hide client.session
70ec4a4
@teogeb
Simplify usage of StreamrClientOptions:
7674733 
    - user sees the type "StreamrClientOptions" where all fields are optional (an optimal type for his own options variable)
    - internally we use "StrictStreamrClientOptions" which has some fields marked as required as those have the default values if the user hasn't specified any value
@timoxley
Add tests around various client export/import methods.
2076b90
timoxley and others added 24 commits March 9, 2021 13:53
@timoxley
Run vendor script after install.
ac087d5
@timoxley
Run test types after build in CI.
f9c6d1a
@timoxley
Debug test-types failure.
15ce740
@timoxley
Fix test-types failure.
8ad474a
@timoxley
Fix test-types failure.
769542e
@timoxley
Vendoring package.json seems to break webpack or babel. Just exclude it.
26a3414
@timoxley
Fix vendor script.
03fe518
@timoxley
Fix vendor script.
88a5383
@teogeb
Update DU factory addresses (dev environment)
5e22862
@jtakalai
WIP: calculate code hash in JS
d5fd552
@teogeb
Naming
320c763
@teogeb
Configure dev environment values for dataUnionTemplateMainnetAddress …
792799e 
…and dataUnionTemplateSidechainAddress
@teogeb
List DU addresses
68164dd
@teogeb
Consistent naming for DU address configs
0af8a42
@teogeb
Fix eslint
1c2c29a
@teogeb
DU production config
01dfee4
@teogeb
Naming
daae35d
@teogeb
Fix eslint
def765f
@timoxley
Don't fail vendor script if quick-lru file exists.
2b49d52
@timoxley
Don't fail vendor script if quick-lru file exists.
cf31462
@teogeb
Merge dataUnion client options
263d733
@teogeb
Modify getSidechainAmb() to be compatible with the new DU contract (t…
b022f84 
…he "data_union_sidechain_factory" method doesn't exists anymore)
@teogeb @jtakalai
payForSignatureTransport -> freeWithdraw and reversed the boolean
4c36d40 
Co-authored-by: jtakalai <jtakalai@users.noreply.github.com>
@teogeb
All dataUnion parameters are optional in StreamrClientOptions
90a3adb
@teogeb teogeb changed the title Export public types Export public types, update DU config Mar 11, 2021
timoxley
timoxley approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@timoxley timoxley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teogeb @jtakalai can you verify those invalid address error messages are correct? but otherwise lgtm. 👍

@teogeb teogeb merged commit 1db5b30 into 5.x Mar 11, 2021
@teogeb teogeb deleted the export-public-types branch March 11, 2021 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@timoxley timoxley timoxley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teogeb @timoxley @jtakalai